Re: postgres_fdw: fix cumulative stats after imported foreign-table stats

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Subject: Re: postgres_fdw: fix cumulative stats after imported foreign-table stats
Date: 2026-07-07 09:50:41
Message-ID: CAPmGK16=f7F8vadOF_iiYmxG5N1E+jfY1jX39mYbV=H8md_Phg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Chao,

On Mon, Jul 6, 2026 at 11:52 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > @@ -230,7 +230,8 @@ analyze_rel(Oid relid, RangeVar *relation,
> > if (fdwroutine->ImportForeignStatistics != NULL &&
> > fdwroutine->ImportForeignStatistics(onerel, va_cols, elevel))
> > stats_imported = true;
> > - else
> > +
> > + if (!stats_imported)
> >
> > Is this a leftover?
>
> Ah, yes, that’s a leftover. Reverted that in v3.

Ok, thanks for updating the patch! Committed and back-patched.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2026-07-07 09:51:04 Re: injection_points: Switch wait/wakeup to use atomics rather than latches
Previous Message Cagri Biroglu 2026-07-07 09:41:55 Per-table resync for logical replication subscriptions