| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Subject: | Re: postgres_fdw: fix cumulative stats after imported foreign-table stats |
| Date: | 2026-07-07 14:22:45 |
| Message-ID: | C423F4B5-55B8-44AE-AB7A-7FC6B8EC1BA7@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jul 7, 2026, at 02:50, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> Hi Chao,
>
> On Mon, Jul 6, 2026 at 11:52 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> @@ -230,7 +230,8 @@ analyze_rel(Oid relid, RangeVar *relation,
>>> if (fdwroutine->ImportForeignStatistics != NULL &&
>>> fdwroutine->ImportForeignStatistics(onerel, va_cols, elevel))
>>> stats_imported = true;
>>> - else
>>> +
>>> + if (!stats_imported)
>>>
>>> Is this a leftover?
>>
>> Ah, yes, that’s a leftover. Reverted that in v3.
>
> Ok, thanks for updating the patch! Committed and back-patched.
>
> Best regards,
> Etsuro Fujita
Thanks for pushing.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-07-07 14:27:24 | Re: Schema-qualify the equality operator when deparsing NULLIF/IS DISTINCT FROM |
| Previous Message | Tom Lane | 2026-07-07 14:17:11 | Re: Add missing CustomPathMethods on typedefs.list |