| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Copy-pasto in comment in ExecAppendAsyncReset |
| Date: | 2026-11-04 09:44:44 |
| Message-ID: | CAPmGK15sC=RCUqUDX-Q7Dz2q_jRDDRnjr2ADwed8i19Rc26k1g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 4, 2026 at 7:21 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > On Nov 3, 2026, at 21:31, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > On Tue, Nov 3, 2026 at 11:51 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >> Should we also update the header comment of ExecAppendAsyncEventWait since it only says “wait or poll” without explaining when to wait and when to poll? Something like:
> >> ```
> >> /*
> >> * ExecAppendAsyncEventWait
> >> *
> >> * Wait or poll for file descriptor events and fire callbacks.
> >> * If as_syncdone is true, wait until at least one event occurs;
> >> * otherwise, poll without waiting so synchronous execution can proceed.
> >> */
> > That would be an improvement rather than a fix, so I'd like to leave
> > it for another (master-only) patch.
> No problem. Would you follow up a patch? Or you’d let me propose one?
Thanks, I've pushed and backpatched the patch. It would be great if
you proposed that one.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-11-04 09:47:03 | Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring |
| Previous Message | Koshino Taiki | 2026-11-04 09:18:59 | Re: [PATCH v1] psql: Do not complete JSON format for COPY FROM |