| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Copy-pasto in comment in ExecAppendAsyncReset |
| Date: | 2026-11-03 22:20:59 |
| Message-ID: | 5B023A23-0C96-4D8E-90CA-0D342F32F007@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 3, 2026, at 21:31, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> On Tue, Nov 3, 2026 at 11:51 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> <fix-comments.patch>
>>
>> The fix looks good to me.
>>
>> Should we also update the header comment of ExecAppendAsyncEventWait since it only says “wait or poll” without explaining when to wait and when to poll? Something like:
>> ```
>> /*
>> * ExecAppendAsyncEventWait
>> *
>> * Wait or poll for file descriptor events and fire callbacks.
>> * If as_syncdone is true, wait until at least one event occurs;
>> * otherwise, poll without waiting so synchronous execution can proceed.
>> */
>> ```
>
> That would be an improvement rather than a fix, so I'd like to leave
> it for another (master-only) patch.
>
No problem. Would you follow up a patch? Or you’d let me propose one?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Jacob Champion | 2026-11-03 21:54:33 | Re: Emptying oauth_validator_libraries doesn't stop OAuth logins |