Re: postgres_fdw: transaction mode inheritance corner cases

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: postgres_fdw: transaction mode inheritance corner cases
Date: 2026-10-05 08:22:54
Message-ID: CAPmGK15m=TT2Y-v-ReN1kD-V9M-tTQeAoxqqgDRdHTNp6ojLgw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 3, 2026 at 9:04 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Sat, Oct 3, 2026 at 6:38 PM Matheus Alcantara
> <matheusssilv97(at)gmail(dot)com> wrote:
> > On Fri Oct 2, 2026 at 12:54 PM -03, Etsuro Fujita wrote:
> > > Here is an updated version for that. This is
> > > an existing issue, so I split it into two:
> > >
> > > * v2-0001-Fix-open-cursor-handling.patch
> > > This addresses the existing issue by disallowing the fetching (and the
> > > issue #1 reported by Fujii-san as a side effect).
> > >
> > > * v2-0002-Fix-xact-prop-issues.patch
> > > This addresses the remaining issues #2, #3 and #5 reported by
> > > Fujii-san (#4 is not a bug). I will add test cases next.
> >
> > Thanks for the v2 patches! I tested them and the hot standby issue is
> > fixed by 0002, and the deferred trigger case works as expected. I found
> > two problems with 0001, 0002 looks good to me.

> I added the test cases to 0002. Attached is a new version of the
> patch. (It actually doesn't depend on 0001, so I'm only attaching
> 0002.) I will push/backpatch the new version first if no objections
> from others.

Done.

> As for 0001, I also noticed problem #1 after sending the email...
> 0001 is an existing issue, so I will return to it, including your
> patch, after closing this open item.

I closed it and added the existing issue to Live issues.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Koshi Shibagaki (Fujitsu) 2026-10-05 08:46:02 Re: [PATCH] pg_walsummary: suppress limit output with --quiet
Previous Message Dongpo Liu 2026-10-05 08:22:52 pg_plan_advice fails on a CustomScan that replaces a join