| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgres_fdw: transaction mode inheritance corner cases |
| Date: | 2026-10-03 12:04:49 |
| Message-ID: | CAPmGK15okNxChu8wB_UwNWKTYbdjY=r3+7Wny3e_-bRrcaE+uA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 3, 2026 at 6:38 PM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
> On Fri Oct 2, 2026 at 12:54 PM -03, Etsuro Fujita wrote:
> > Here is an updated version for that. This is
> > an existing issue, so I split it into two:
> >
> > * v2-0001-Fix-open-cursor-handling.patch
> > This addresses the existing issue by disallowing the fetching (and the
> > issue #1 reported by Fujii-san as a side effect).
> >
> > * v2-0002-Fix-xact-prop-issues.patch
> > This addresses the remaining issues #2, #3 and #5 reported by
> > Fujii-san (#4 is not a bug). I will add test cases next.
>
> Thanks for the v2 patches! I tested them and the hot standby issue is
> fixed by 0002, and the deferred trigger case works as expected. I found
> two problems with 0001, 0002 looks good to me.
Thanks for reviewing!
I added the test cases to 0002. Attached is a new version of the
patch. (It actually doesn't depend on 0001, so I'm only attaching
0002.) I will push/backpatch the new version first if no objections
from others.
As for 0001, I also noticed problem #1 after sending the email...
0001 is an existing issue, so I will return to it, including your
patch, after closing this open item. Thanks for the patch!
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Fix-xact-prop-issues.patch | application/octet-stream | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Alvaro Herrera | 2026-10-03 11:35:14 | Re: REPACK (CONCURRENTLY) might keep dropped-column data |