Re: Multi-insert related comment in CopyFrom()

On Wed, Sep 21, 2022 at 4:39 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> While working on the “Fast COPY FROM based on batch insert” patch, I
> noticed this:
>
> else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&
> resultRelInfo->ri_TrigDesc->trig_insert_new_table)
> {
> /*
> * For partitioned tables we can't support multi-inserts when there
> * are any statement level insert triggers. It might be possible to
> * allow partitioned tables with such triggers in the future, but for
> * now, CopyMultiInsertInfoFlush expects that any before row insert
> * and statement level insert triggers are on the same relation.
> */
> insertMethod = CIM_SINGLE;
> }
>
> I think there is a thinko in the comment; “before” should be after.
> Patch attached.

Pushed.

Best regards,
Etsuro Fujita