Re: use of SPI by postgresImportForeignStatistics

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use of SPI by postgresImportForeignStatistics
Date: 2026-07-18 18:59:31
Message-ID: CAPmGK14nAf_+Ge4cfgEcJ07d0=3=GmVdEO-bGWfvi_5SNb8mgA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 17, 2026 at 6:59 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> Here is a (further) cleanup:
>
> postgres_fdw passes the remote-server version, which is of type int,
> to the new stats-import functions, using UInt32GetDatum not
> Int32GetDatum. This is completely harmless because the version is 1)
> positive and 2) currently ignored in those functions, but let's modify
> that code to use Int32GetDatum for consistency. Attached is a small
> patch for that. I'll push and back-patch it if no objections.

Pushed and backpatched to v19.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2026-07-18 19:05:47 Re: Bug in asynchronous Append
Previous Message Tom Lane 2026-07-18 18:47:43 Re: CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS