| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-07-17 09:59:59 |
| Message-ID: | CAPmGK14aremJGrPezVwFqWt7dnrMhD3KF1DgzsRygAUPETBU7w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2026 at 2:03 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> Committed and back-patched.
Here is a (further) cleanup:
postgres_fdw passes the remote-server version, which is of type int,
to the new stats-import functions, using UInt32GetDatum not
Int32GetDatum. This is completely harmless because the version is 1)
positive and 2) currently ignored in those functions, but let's modify
that code to use Int32GetDatum for consistency. Attached is a small
patch for that. I'll push and back-patch it if no objections.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| GetDatum-cleanup.patch | application/octet-stream | 532 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-07-17 10:00:21 | Re: doc: clarify wal_sender_shutdown_timeout behavior for small values |
| Previous Message | Nazir Bilal Yavuz | 2026-07-17 09:41:04 | Re: ci: namespace ccache by PostgreSQL major version |