| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-06-18 10:42:56 |
| Message-ID: | CAPmGK14P2GRe78hp6fZ3vExU_9RRDjMsYVOx7AALvUQ-hKTUiQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2026 at 1:00 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
>> IMO I don't think we need to go that far, because 1) the new functions
>> are provided for FDW authors only, and 2) we don't make changes to the
>> stats that often.
>
>
> That would be simpler, to be sure. However, in the past I've received pushback on functions that had a large number of parameters, and this would definitely be a large number of parameters, approximately 17, so I thought I should at least offer the variadic way.
>
> I'm proceeding with the many-parameters model.
I think that that's acceptable, considering that
heap_create_with_catalog() has 21 parameters.
Thanks!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-06-18 10:43:51 | Re: Row pattern recognition |
| Previous Message | Tatsuo Ishii | 2026-06-18 09:50:07 | Re: Row pattern recognition |