Re: use of SPI by postgresImportForeignStatistics

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use of SPI by postgresImportForeignStatistics
Date: 2026-06-17 16:00:02
Message-ID: CADkLM=dr5bfB8YN-bV1U0NDvyVO7a6uuz0BsAi89a1Md4A==8g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
>
> IMO I don't think we need to go that far, because 1) the new functions
> are provided for FDW authors only, and 2) we don't make changes to the
> stats that often.
>

That would be simpler, to be sure. However, in the past I've received
pushback on functions that had a large number of parameters, and this would
definitely be a large number of parameters, approximately 17, so I thought
I should at least offer the variadic way.

I'm proceeding with the many-parameters model.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2026-06-17 16:01:28 Re: Direction for test frameworks: Perl TAP vs. Python/pytest
Previous Message Melanie Plageman 2026-06-17 15:50:57 Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0