| From: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
|---|---|
| To: | masao(dot)fujii(at)gmail(dot)com |
| Cc: | rajeshkumarth(at)google(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, kehan5800(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com, dilipkumarb(at)google(dot)com |
| Subject: | Re: Re: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup |
| Date: | 2026-11-16 06:03:01 |
| Message-ID: | CAPHduZCUui51Cmk2MZx0CzbV36W0qkJo7aTHTyTO+z2KK7YcaQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Hi Fujii-san,
I checked this by running
https://www.google.com/url?q=http://011_ib_truncation.pl&source=gmail&ust=1794895380937000&sa=E
against current master without the reconstruct.c change, varying $copy_rows
(1, 4, 16, 17, 18, 32, 100) and shared_buffers (8MB, 16MB, 128MB). The new
subtest catches the bug in only 6 of the 21 combinations (copy_rows 16-17
with 8MB, 17-18 with 16MB and 128MB); in all the others it passes without
the fix. So I agree it depends too much on COPY's batching to be a reliable
regression test, and dropping it makes sense, since the reproducer upthread
already demonstrates the bug and the fix.
Regards,
Sai Pranav
On Mon, Nov 16, 2026 10:42 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Sun, Nov 8, 2026 at 12:21 AM Raja Sai pranav
> <rajasaipranav0(at)gmail(dot)com> wrote:
> > - v3 now adds the bulk-extension regression test I'd flagged as missing:
> the
> > node3 / incr2-incr4 chain that bumps shared_buffers so COPY bulk-extends
> the
> > relation past an intermediate truncation point, leaving zero-filled
> unwritten
> > pages in the truncated range.
>
> I just wonder if the added test might be fragile. It relies on internal
> logics, such as COPY's batching behavior ($copy_rows = 17), buffer pin
> limits (shared_buffers = 8MB), and the bulk-extension strategy leaving
> pages unwritten. Changes to any of these could easily make the test pass
> even without the fix. No?
>
> If so, isn't it better to leave out the test for now? Also because
> the reproducer has already demonstrated the bug and the fix.
>
> Regards,
>
>
> --
> Fujii Masao
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rui Zhao | 2026-11-16 07:47:27 | Re: Two bugs around ALTER TYPE |
| Previous Message | Fujii Masao | 2026-11-16 05:12:46 | Re: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao Rito | 2026-11-16 06:07:00 | Re: [PATCH] contrib/fuzzystrmatch: improve test coverage |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-11-16 05:53:13 | RE: Patch for migration of the pg_commit_ts directory |