| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Raja Sai pranav <rajasaipranav0(at)gmail(dot)com> |
| Cc: | rajeshkumarth(at)google(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, kehan5800(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, robertmhaas(at)gmail(dot)com, dilipkumarb(at)google(dot)com |
| Subject: | Re: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup |
| Date: | 2026-11-16 05:12:46 |
| Message-ID: | CAHGQGwHu43pM9QsidJW880uqUqi3P2sTK-1yS31sd+OKcWv-Og@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Sun, Nov 8, 2026 at 12:21 AM Raja Sai pranav
<rajasaipranav0(at)gmail(dot)com> wrote:
> - v3 now adds the bulk-extension regression test I'd flagged as missing: the
> node3 / incr2-incr4 chain that bumps shared_buffers so COPY bulk-extends the
> relation past an intermediate truncation point, leaving zero-filled unwritten
> pages in the truncated range.
I just wonder if the added test might be fragile. It relies on internal
logics, such as COPY's batching behavior ($copy_rows = 17), buffer pin
limits (shared_buffers = 8MB), and the bulk-extension strategy leaving
pages unwritten. Changes to any of these could easily make the test pass
even without the fix. No?
If so, isn't it better to leave out the test for now? Also because
the reproducer has already demonstrated the bug and the fix.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Raja Sai pranav | 2026-11-16 06:03:01 | Re: Re: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup |
| Previous Message | shveta malik | 2026-11-16 04:55:48 | Re: BUG #19864: pg_get_publication_tables() gets cache lookup error after concurrent DROP PUBLICATION |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-11-16 05:26:45 | Re: 041_checkpoint_at_promote.pl might fail due to race condition on child kill |
| Previous Message | Amit Kapila | 2026-11-16 05:00:54 | Re: Assertion failure in update_local_synced_slot(), slotsync.c:364 |