Re: Re: Assertion failure in WAL summarizer

Hi,

I re-tested the v4 series on current master (76c0df7).

- All three patches apply cleanly with `git am` (0001, 0002, 0003).
- Builds with --enable-cassert --enable-debug --enable-tap-tests, no new
warnings.
- Both affected TAP suites are green on an assert-enabled build:
- pg_combinebackup: Files=16, Tests=147, Result: PASS
(new t/
https://www.google.com/url?q=http://015_summary_past_switch.pl&source=gmail&ust=1794453437308000&sa=E
and t/
https://www.google.com/url?q=http://016_truncation_after_target.pl&source=gmail&ust=1794453437308000&sa=E
both ok)
- pg_walsummary: Files=4, Tests=34, Result: PASS
(new t/
https://www.google.com/url?q=http://004_promote_past_target.pl&source=gmail&ust=1794453437308000&sa=E
ok)

Since this is a cassert build, t/
https://www.google.com/url?q=http://004_promote_past_target.pl&source=gmail&ust=1794453437308000&sa=E
and
t/
https://www.google.com/url?q=http://015_summary_past_switch.pl&source=gmail&ust=1794453437308000&sa=E
exercising the promote/timeline-switch paths
without tripping an assertion is the result we want.

As you say, v4 is a straight rebase of v3 with no code changes, so this just
confirms it still applies and passes cleanly on today's master. LGTM from my
side.

Regards,
Sai Pranav

On Wed, Nov 11, 2026 08:04 AM, shihao zhong <zhong950419(at)gmail(dot)com> wrote:

> Hi,
>
> v3 no longer applies on master. I did not see any new comments.
>
> So v4 is just a rebase.
>
> Thanks,
>
>
>
>
>