| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and [un]loggedness |
| Date: | 2025-06-05 01:04:23 |
| Message-ID: | CAOzEurS=3xu8WV6KRmc-axLn5tUs_5Ggy0DY_Gj8XcFOJTDeWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 5, 2025 at 9:23 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Agreed to not suggest the PARTITION BY clause in the tab completion as
> it is not supported by the backend for unlogged tables.
> tab-complete.in.c has some handling for CREATE UNLOGGED TABLE around
> line 3667, so we could just have an extra case for it, like in the
> attached patch. A split already exists for temporary tables to handle
> the ON COMMIT clause after the attribute list.
>
> Thoughts?
Thank you. It looks good to me.
--
Best regards,
Shinya Kato
NTT OSS Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-06-05 01:08:35 | psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM |
| Previous Message | Michael Paquier | 2025-06-05 01:00:42 | Re: Improve explicit cursor handling in pg_stat_statements |