Re: Logical Replication of sequences

From: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2025-11-06 02:29:31
Message-ID: CAOzEurQOSN=Zcp9uVnatNbAy=2WgMTJn_DYszYjv0KUeQX_e_A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 5, 2025 at 5:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I have pushed the 0001 after making minor adjustments in tests and at
> a few other places. Kindly rebase and send the remaining patches.

I discovered that the sequence sync worker fails for sequences
containing single quotes.
---
2025-11-06 10:22:50.335 JST [1096008] ERROR: could not fetch sequence
information from the publisher: ERROR: syntax error at or near
"quote"
LINE 4: FROM ( VALUES ('public', 'regress'quote', 0), ('public', 'ho...
^
2025-11-06 10:22:50.335 JST [1088168] LOG: background worker "logical
replication sequencesync worker" (PID 1096008) exited with exit code 1
---

I haven't read all the threads, so I might be mistaken, but I've
created a patch.

--
Best regards,
Shinya Kato
NTT OSS Center

Attachment Content-Type Size
fix-logical-sequence-sync-quoted-names.diff application/octet-stream 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-11-06 02:45:58 Re: Docs and tests for RLS policies applied by command type
Previous Message David Rowley 2025-11-06 02:09:02 Re: Use stack-allocated StringInfoData