Re: Use stack-allocated StringInfoData

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Mats Kindahl <mats(dot)kindahl(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use stack-allocated StringInfoData
Date: 2025-11-06 02:09:02
Message-ID: CAApHDvqmChZcq6SKWvECYhExey+=Nmm=fASSwFnn9groX4tGeg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 6 Nov 2025 at 00:01, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I can push this tomorrow morning UTC+13. I'll leave it til then in
> case anyone else has any comments.

I found a few more cases that could get the same treatment and also
included the check_publications() one mentioned by Chao.

I did end up removing the subscriptioncmds.c. I thought those should
likely just be fixed to use errmsg() and errhint() instead of their
"internal" counterpart.

I left out the Coccinelle script. I'm not currently qualified to
review that, and not aware of the policy about that. I'm aware there's
another thread with some discussion about Coccinelle, but I've not
read it.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinya Kato 2025-11-06 02:29:31 Re: Logical Replication of sequences
Previous Message Xuneng Zhou 2025-11-06 02:01:10 Re: pgstattuple: Use streaming read API in pgstatindex functions