Re: Issue in recent pg_stat_statements?

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Issue in recent pg_stat_statements?
Date: 2021-04-26 15:40:21
Message-ID: CAOxo6X+Giy8M31b-dEGFMZrPyLPWeAES6+2uB8wijLRFrbJj9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> > Is this an expected change, or is this in fact broken? In previous
> revisions, this was showing the INSERT and SELECT at the very least. I'm
> unclear as to why the regression test is still passing, so want to verify
> that I'm not doing something wrong in the testing.
>
> Yes, you want to look into the queryid functionality. See
>
> https://www.postgresql.org/message-id/flat/35457b09-36f8-add3-1d07-6034fa585ca8%40oss.nttdata.com
>
> Interface changes may still be coming in 14 for that. Or warnings.
>

Hmm, I'm unclear as to why you would potentially want to use
pg_stat_statements *without* this functionality. At the very least, it
violates POLA — I spent the better part of a day thinking this was a bug
due to the expected behavior being so obvious I wouldn't have expected any
different.

In any case, this discussion is better had on a different thread. Thanks
at least for explaining what I was seeing.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-04-26 15:40:25 Re: Enhanced error message to include hint messages for redundant options error
Previous Message Christoph Berg 2021-04-26 15:34:30 Re: compute_query_id and pg_stat_statements