| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: WAL prefetch (another approach) |
| Date: | 2021-04-21 23:22:33 |
| Message-ID: | CAOuzzgrn7iKnFRsB4MHp3UisEQAGgZMbk_ViTN4HV4-Ksq8zCg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
On Wed, Apr 21, 2021 at 19:17 Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Thu, Apr 22, 2021 at 8:16 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
> wrote:
> > That wasn't my plan, but I admit that the timing was non-ideal. In
> > any case, I'll dig into these failures and then consider options.
> > More soon.
>
> Yeah, this clearly needs more work. xlogreader.c is difficult to work
> with and I think we need to keep trying to improve it, but I made a
> bad call here trying to combine this with other refactoring work up
> against a deadline and I made some dumb mistakes. I could of course
> debug it in-tree, and I know that this has been an anticipated
> feature. Personally I think the right thing to do now is to revert it
> and re-propose for 15 early in the cycle, supported with some better
> testing infrastructure.
I tend to agree with the idea to revert it, perhaps a +0 on that, but if
others argue it should be fixed in-place, I wouldn’t complain about it.
I very much encourage the idea of improving testing in this area and would
be happy to try and help do so in the 15 cycle.
Thanks,
Stephen
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | yuzuko | 2021-04-21 23:30:52 | Re: pgsql: autovacuum: handle analyze for partitioned tables |
| Previous Message | Thomas Munro | 2021-04-21 23:16:17 | Re: WIP: WAL prefetch (another approach) |