Re: preprocess_targetlist and inheiritance

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: preprocess_targetlist and inheiritance
Date: 2015-04-21 15:43:27
Message-ID: CAOuzzgrDOs7ph0+Dmv+RjWJqqhf5zoke2i_uGjivytcjWx2CEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro,

On Tuesday, April 21, 2015, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> Stephen Frost wrote:
> > Tom, all,
> >
> > Looks like preprocess_targetlist() should have been adjusted with the
> > changes to ExecBuildAuxRowMark() to support foreign tables being part
> > of inheritance trees (cb1ca4d800621dcae67ca6c799006de99fa4f0a5) to
> > also include the tableoid regardless of the rowMark type, if the
> > relation is the parent of an inheritance tree.
>
> Uh, this patch was already submitted separately:
> https://www.postgresql.org/message-id/552CF0B6.8010006@lab.ntt.co.jp

Oh, excellent. Looks like the discussion agrees that it makes sense to do
and the RLS case didn't involve any foreign tables yet still ran into the
issue.

Is that correct or am I missing something?

Apologies, on my mobile currently.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-04-21 15:58:05 Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Previous Message Andres Freund 2015-04-21 15:40:52 Re: Freeze avoidance of very large table.