Re: [PATCH] Include application_name in "connection authorized" log message

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Don Seiler <don(at)seiler(dot)us>
Cc: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Include application_name in "connection authorized" log message
Date: 2018-06-25 20:32:05
Message-ID: CAOuzzgqbONNyUiuH_uQhF75h-1NOw-=zwBaFU+45HRUKggccWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings

On Mon, Jun 25, 2018 at 15:57 Don Seiler <don(at)seiler(dot)us> wrote:

> On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
> wrote:
>
>> I would prefer the following output to conform to elog.c output:
>>
>> 2018-06-25 17:32:46.854 CEST [23265] LOG: connection authorized:
>> user=postgres database=postgres application=[unknown]
>>
> Hello Gilles,
>
> The different cases were for Stephen's request earlier in this thread. I'm
> happy to write it either way and agree it would be nice to not have a lot
> of duplicate code. Do you want me to submit another patch?
>

I think it’s better to not change the line when application name isn’t
being set, as the latest patch has. That also matches how we handle the SSL
info- it’s only shown if ssl is in place on the connection.

Thanks!

Stephen

>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gilles Darold 2018-06-25 20:56:10 Re: [PATCH] Include application_name in "connection authorized" log message
Previous Message Don Seiler 2018-06-25 19:57:08 Re: [PATCH] Include application_name in "connection authorized" log message