Re: [PATCH] Include application_name in "connection authorized" log message

Le 25/06/2018 à 22:32, Stephen Frost a écrit :
> Greetings
>
> On Mon, Jun 25, 2018 at 15:57 Don Seiler <don(at)seiler(dot)us
> <mailto:don(at)seiler(dot)us>> wrote:
>
> On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold
> <gilles(dot)darold(at)dalibo(dot)com <mailto:gilles(dot)darold(at)dalibo(dot)com>> wrote:
>
> I would prefer the following output to conform to elog.c output:
>
>     2018-06-25 17:32:46.854 CEST [23265] LOG: connection
> authorized: user=postgres database=postgres application=[unknown]
>
> Hello Gilles,
>
> The different cases were for Stephen's request earlier in this
> thread. I'm happy to write it either way and agree it would be
> nice to not have a lot of duplicate code. Do you want me to submit
> another patch?
>
>
> I think it’s better to not change the line when application name isn’t
> being set, as the latest patch has. That also matches how we handle
> the SSL info- it’s only shown if ssl is in place on the connection.

Oh ok, sorry Stephen I've not seen your anwser before my last reply. I
would prefer to have the information that the application_name is
unknown but this is just to conform with the log parser and obviously
the actual patch is enough, I change the status to "ready for
committer", nothing need to be change.

--
Gilles Darold
Consultant PostgreSQL
http://dalibo.com - http://dalibo.org