Re: Add mode column to pg_stat_progress_vacuum

From: Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>
To: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add mode column to pg_stat_progress_vacuum
Date: 2025-11-19 07:56:24
Message-ID: CAOtHd0DTL471tpDKH4H37oVQ_X90w0b2ekcrPqmUmWPxV+SRyg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 18, 2025, 21:10 Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> wrote:

> On Wed, Nov 19, 2025 at 9:04 AM Masahiko Sawada
> <sawada(dot)mshk(at)gmail(dot)com> > > Fixed, but I have a comment. I noticed
> minor wording inconsistencies,
> > > e.g., 'started' vs. 'initiated' and 'due to' vs. 'because of'. Should
> > > I unify these terms?
> >
> > +1
>
> It seems the inconsistency between 'started' and 'initiated' has not
> been resolved. Come to think of it, since the column name is
> triggerd_by, I think it would be best to standardize on 'triggered'. I
> have attached a patch to fix this.

I'm late to the discussion, but have you considered just "trigger" for the
column name? It's shorter and just as clear.

In any case, thanks for working on and reviewing this—it's a handy addition!

Thanks,
Maciek

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-11-19 07:57:28 Re: Reorganize GUC structs
Previous Message Jim Jones 2025-11-19 07:52:49 Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement