| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: concerns around pg_lsn |
| Date: | 2019-08-01 07:09:26 |
| Message-ID: | CAOgcT0NUvGWuSbkOH4z_MPk=6Sfno5uEzSUf83YTDzXQZMnNUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
> I will further check if by mistake any further commits have removed
> > references to assignments from float8in_internal_opt_error(),
> > evaluate it, and set out a patch.
>
> Thanks, Jeevan!
>
Here is a patch that takes care of addressing the flag issue including
pg_lsn_in_internal() and others.
I have further also fixed couple of other functions,
numeric_div_opt_error() and
numeric_mod_opt_error() which are basically callers of
make_result_opt_error().
Kindly do let me know if you have any comments.
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Make-the-have_error-flag-initialization-more-defensi.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavlo Golub | 2019-08-01 07:12:12 | Re: Commitfest 2019-07, the first of five* for PostgreSQL 13 |
| Previous Message | Thomas Munro | 2019-08-01 07:02:12 | Re: dropdb --force |