| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: concerns around pg_lsn |
| Date: | 2019-08-01 06:01:33 |
| Message-ID: | 20190801060133.GC3435@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 01, 2019 at 11:14:32AM +0530, Jeevan Ladhe wrote:
> Sure, agree, it makes sense to address float8in_internal_opt_error(),
> there might be more occurrences of such instances in other functions
> as well. I think if we agree, as and when encounter them while touching
> those areas we should fix them.
I have spotted a third area within make_result_opt_error in numeric.c
which could gain readability by initializing have_error if the pointer
is defined.
> I will further check if by mistake any further commits have removed
> references to assignments from float8in_internal_opt_error(),
> evaluate it, and set out a patch.
Thanks, Jeevan!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2019-08-01 06:11:33 | Re: How to retain lesser paths at add_path()? |
| Previous Message | Kuntal Ghosh | 2019-08-01 06:01:32 | Re: Remove HeapTuple and Buffer dependency for predicate locking functions |