| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: concerns around pg_lsn |
| Date: | 2019-08-05 03:45:02 |
| Message-ID: | CAOgcT0MTVCXbiOH_peHuoSemXE8Z6AkatZAJkjS-1Kjq6Sz0QQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 4, 2019 at 12:13 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sat, Aug 03, 2019 at 11:57:01PM -0400, Alvaro Herrera wrote:
> > Can we please change the macro definition so that have_error is one of
> > the arguments? Having the variable be used inside the macro definition
> > but not appear literally in the call is quite confusing.
>
Can't agree more. This is where I also got confused initially and thought
the flag is unused.
Good idea. This needs some changes only in float.c.
Please find attached patch with the changes to RETURN_ERROR and
it's references in float.c
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Make-have_error-initialization-more-defensive-v3.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-08-05 03:54:41 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | Alexander Lakhin | 2019-08-05 03:44:46 | Re: Fix typos and inconsistencies for HEAD (take 9) |