Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands

From: Israel Barth Rubio <barthisrael(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands
Date: 2022-11-25 15:17:02
Message-ID: CAO_rXXCqRiPLWjAKxP5P4RfTHWhwn-eo-uZeURib1umQSaEoag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> Attached is a draft patch along the lines I speculated about above.
> It breaks backwards compatibility in that PreventInTransactionBlock
> commands will now be rejected if they're a non-first command in a
> pipeline. I think that's okay, and arguably desirable, for HEAD
> but I'm pretty uncomfortable about back-patching it.

I attempted to run these using HEAD, and it fails:

parse: create temporary table t1 (a int) on commit drop
bind
execute
parse: analyze t1
bind
execute
parse: select * from t1
bind
execute
sync

It then works fine after applying your patch!

Just for some context, this was brought by Peter E. based on an issue
reported by a customer. They are using PostgreSQL 11, and the issue
was observed after upgrading to PostgreSQL 11.17, which includes the
commit 9e3e1ac458abcda5aa03fa2a136e6fa492d58bd6. As a workaround
they downgraded the binaries to 11.16.

It would be great if we can back-patch this to all supported versions,
as the issue itself is currently affecting them all.

Regards,
Israel.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2022-11-25 15:50:57 Bug or intentionally under-documented "\c databasename;" behavior?
Previous Message Amit Kapila 2022-11-25 10:08:42 Re: Incorrect messages emitted from pgoutput when using column lists

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimos Stamatakis 2022-11-25 15:46:08 Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency
Previous Message David G. Johnston 2022-11-25 15:10:43 Re: [DOCS] Stats views and functions not in order?