Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)
Date: 2026-03-10 23:27:24
Message-ID: CAOYmi+nWwDQmXLDhH+vmpyp-Y-ELydxv6sg8Oy81qvYUFn+vxg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 10, 2026 at 3:10 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> +#define MASK_BITS ((uintptr_t) 0x55aa55aa55aa55aa)
>
> Won't this cause a warning in 32 bit builds? (0x55aa55aa definitely
> should work in both?)

Hopefully not -- it's an explicit rather than implicit truncation, and
we've required 64-bit integer support from our compilers for a long
time now. But I'm bad at keeping the rules in my head; did you have a
particular compiler in mind?

(The 32-bit build in Cirrus doesn't seem to mind this, though it does
mind the unused variables that I forgot to wrap in USE_VALGRIND...
will fix.)

--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-03-10 23:27:59 Re: Streamify more code paths
Previous Message Andres Freund 2026-03-10 23:04:37 Re: Streamify more code paths