Re: pg_createsubscriber does not check output_plugin_libraries

On Fri, Sep 11, 2026 at 2:45 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> > TBH, the code for checking output_plugin_libraries seems to be getting
> > more complicated than I initially expected. But, from my view, it hasn't
> > become complicated and difficult enough to justify leaving the check out,
> > at least *for now*.
>
> OK, so let's keep working on the patch set. Patches in [1] are still valid.
> We can consider again after the patch will be a committable shape.

Sounds good.

> + /*
> + * Should not happen. (Frontend and backend GUC_LIST_QUOTE parsing
> + * have to remain compatible for pg_dump at minimum.)
> + */

I spun for a while on the network compatibility implications of this,
until I realized that pg_createsubscriber isn't going to work if the
source server is a different major version (even though it doesn't
explicitly check the source server's version, AFAICT?). If that's
correct, this code should be fine. I haven't reviewed line-by-line,
but the general approach LGTM.

Thanks!
--Jacob