| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Explain what the default output_plugin_libraries do |
| Date: | 2026-09-14 23:55:47 |
| Message-ID: | CAOYmi+n0agK=Yt6S8SFSykyRD-1-U_czPEn5z4DhkvwuKWcndA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the review!
On Thu, Sep 10, 2026 at 5:50 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> 1/ "publication slot creation" seems a bit confusing. How about we say
> "Removing pgoutput from output_plugin_libraries will cause future
> subscription connections and replication slot creations on the
> publisher to fail."
One of my early drafts used "replication slot", but that's not
correct. Only the creation of a slot for _publications_ will fail in
most common usage. Unless I'm missing something?
> Just curious, do we need to backpatch this to all the supported
> branches? Removing these can have consequences that show up later, so
> backpatching makes sense to me.
That's my plan, yeah.
Thanks,
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul Kim | 2026-09-14 23:59:26 | Re: Be strict when request to flush past end of WAL in WaitXLogInsertionsToFinish |
| Previous Message | Jacob Champion | 2026-09-14 23:47:26 | Re: pg_createsubscriber does not check output_plugin_libraries |