Re: unclear OAuth error message

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Subject: Re: unclear OAuth error message
Date: 2026-04-01 22:57:10
Message-ID: CAOYmi+mvFS7Ukmacb1z=xWO7M+DPF41GZsJiJ6sh4U1Qm_yWOA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 27, 2026 at 4:20 PM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> I don't think I can enforce either choice, though: I pass the
> error_detail into the ereport(FATAL), so the process is about to go
> down, and I'm never going to pfree() it.

(I also think it's reasonable to do something like

res->error_detail = "Help! it's again.";

if there's nothing to format, without mandating a superfluous pstrdup().)

v4 rebases, incorporates Chao Li's feedback, rewrites the surrounding
paragraph a bit, and fixes a silly misuse of <xref> when I meant
<link>.

--Jacob

Attachment Content-Type Size
v4-0001-oauth-Let-validators-provide-failure-DETAILs.patch application/octet-stream 12.9 KB
since-v3.nocfbot.diff application/octet-stream 3.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2026-04-01 22:59:24 Re: [oauth] Split and extend PGOAUTHDEBUG
Previous Message Peter Geoghegan 2026-04-01 22:50:15 Re: index prefetching