Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647]

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Edwin Polkerman <edwin(dot)polkerman(at)splendiddata(dot)com>
Subject: Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647]
Date: 2026-09-03 18:30:23
Message-ID: CAOYmi+kDSmfQS-H9xE2kbpUNdXNicSgEyqMaXe5EnF1wXU-K7Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Sep 3, 2026 at 10:29 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> > I'm not sure I have a strong preference, keeping it in sync with pg_basebackup
> > seems like a pretty good strategy to make it easier for users.
>
> It looks to me like there was a fair amount of consensus behind
> 025584a16, so I think we should conclude that pg_basebackup's new
> behavior (ignore stray files) is the right thing and it was an
> oversight that pg_checksums wasn't adjusted similarly.

Sounds good, thanks both! Attached is the simplest thing that could
fix the reported problem (and nothing else), but I'd rather look into
moving parse_filename_for_nontemp_relation() to common/relfile.c so it
can be used directly. I probably won't have time for that today.

--Jacob

Attachment Content-Type Size
0001-WIP-pg_checksums-Ignore-more-stray-files-in-director.patch application/octet-stream 2.5 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrey Rachitskiy 2026-09-03 18:36:06 Re: BUG #19652: to_number() silently truncates over-length integers
Previous Message Tom Lane 2026-09-03 17:29:43 Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647]

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-09-03 18:42:09 Re: Remove fcinfo from statistics update internal functions
Previous Message Nathan Bossart 2026-09-03 18:21:24 Re: Speed up COPY TO text/CSV parsing using SIMD