| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Edwin Polkerman <edwin(dot)polkerman(at)splendiddata(dot)com> |
| Subject: | Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647] |
| Date: | 2026-09-03 17:29:43 |
| Message-ID: | 1477911.1788456583@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> On 3 Sep 2026, at 19:10, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>> The inciting event is that an extension drops a file called
>> pgactive.stat into global/. We could say "don't do that", in which
>> case I think we should follow Robert's idea in [1] and complain about
>> the existence of the file itself rather than the lack of checksummable
>> material. Or we could say "that's fine" and adjust pg_checksums to
>> continue onwards if the filename isn't what we expect.
> I'm not sure I have a strong preference, keeping it in sync with pg_basebackup
> seems like a pretty good strategy to make it easier for users.
It looks to me like there was a fair amount of consensus behind
025584a16, so I think we should conclude that pg_basebackup's new
behavior (ignore stray files) is the right thing and it was an
oversight that pg_checksums wasn't adjusted similarly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-09-03 18:30:23 | Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647] |
| Previous Message | Daniel Gustafsson | 2026-09-03 17:20:52 | Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647] |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Osama Abdul Qader | 2026-09-03 17:35:09 | Re: REPACK (ANALYZE) within transaction block segfaults |
| Previous Message | Daniel Gustafsson | 2026-09-03 17:20:52 | Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647] |