Re: pgsql: libpq: Grease the protocol by default

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: libpq: Grease the protocol by default
Date: 2026-02-24 01:05:45
Message-ID: CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Feb 23, 2026 at 4:45 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> > Something like the attached (tested only against 9.2 so far)? I would
> > plan to backpatch after feature freeze is lifted.

(er, should have been "release freeze", though we're clearly in no hurry)

> Also: I was initially baffled why you thought this needs
> back-patching, but I guess you have one eye on packagers like
> Debian who think they can make older versions use newer libpq.so.

Right.

> It'd be good to spell out that reasoning in the commit message.

Okay, will do.

> It's not obvious to me where the problem lies. I can replicate
> the failure by trying to use HEAD's psql to connect to a 9.2
> server, but adding -d "max_protocol_version=3.0" makes psql happy,
> so why not pg_dumpall?

Hmmm, looks like the -dump1.log output is actually from *before*
pg_upgrade actually runs:

https://github.com/PGBuildFarm/client-code/blob/28d7e945cc2a27fecdf4cc685782821ca504db5d/PGBuild/Modules/TestUpgradeXversion.pm#L514

So that will still need to be modified in the buildfarm client,
independently of my patch. (I reproduced the error with a bare
pg_upgrade invocation and didn't think to look closer; sorry for the
confusion.)

--Jacob

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-02-24 01:17:23 Re: pgsql: libpq: Grease the protocol by default
Previous Message Tom Lane 2026-02-24 00:45:05 Re: pgsql: libpq: Grease the protocol by default

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexandra Wang 2026-02-24 01:10:02 Re: pg_plan_advice
Previous Message Tom Lane 2026-02-24 00:45:05 Re: pgsql: libpq: Grease the protocol by default