Re: pgsql: libpq: Grease the protocol by default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: libpq: Grease the protocol by default
Date: 2026-02-24 01:17:23
Message-ID: 3829701.1771895843@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> It's not obvious to me where the problem lies.

Ah: the step that is failing is where TestUpgradeXVersion.pm
is trying to make a comparison dump from the old server:

# use the NEW pg_dumpall so we're comparing apples with apples.
setinstenv($self, "$installdir", $save_env);
system( qq{"$installdir/bin/pg_dumpall" $dump_opts -p $sport -f }
. qq{"$upgrade_loc/origin-$oversion.sql" }
. qq{> "$upgrade_loc/$oversion-dump1.log" 2>&1});
return if $?;

So I was right to suspect that we can't fix this without modifying
the buildfarm client.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-02-24 02:08:56 Re: pgsql: libpq: Grease the protocol by default
Previous Message Jacob Champion 2026-02-24 01:05:45 Re: pgsql: libpq: Grease the protocol by default

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-02-24 01:21:50 Re: Support logical replication of DDLs
Previous Message jian he 2026-02-24 01:10:46 Re: pg_dumpall --roles-only interact with other options