Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: [oauth] Increased CPU usage during device flow with libcurl 8.20.0
Date: 2026-06-15 22:56:52
Message-ID: CAOYmi+=kP86t+ZFFXNQ9G6K4ht7utdmB=CzhP=Z2wvuBymOTtQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 15, 2026 at 12:47 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
> > So that just leaves what to do about the current test failures. My
> > current idea is to just skip the test if the curl binary reports that
> > specific minor version.
>
> Seems like a good solution. We don't know how long such curl
> binaries will persist in the wild.

Cool. Unfortunately, I immediately ran into an obvious-in-retrospect
problem: the Homebrew libcurl we're linked against is not what you see
when you type `curl --version` at the command line, and I don't think
we record the runtime version of libcurl anywhere today. I've attached
a solution that should work well for PG20, but I don't feel as good
about it for 19 (or a backport to 18).

I need to switch to a different context for today, but tomorrow I'll
try to find a solution that touches only the test code.

Thanks,
--Jacob

Attachment Content-Type Size
0001-oauth_validator-Print-captured-stderr-after-call-cou.patch application/octet-stream 1.3 KB
0002-libpq-oauth-Print-libcurl-version-with-OAUTHDEBUG_UN.patch application/octet-stream 3.6 KB
0003-oauth-Skip-call-count-test-for-libcurl-8.20.0.patch application/octet-stream 2.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2026-06-15 23:20:02 Re: Heads Up: cirrus-ci is shutting down June 1st
Previous Message Sami Imseih 2026-06-15 22:55:35 Re: [PATCH] COPY TO FORMAT json: respect column list order