| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Masao Fujii <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Revert online data checksum transitions |
| Date: | 2026-09-16 17:33:57 |
| Message-ID: | CAOYmi+=-_he-goOPnhabE6Gs=m5gQ_tj_T=PWwcd_Tgo4ZKSGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Sep 16, 2026 at 10:14 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> However, what I'm seeing as I trace through the crash on
> longfin is that nulls[19] has a value that's not either 0 or 1 (not
> too surprising), and somehow heap_compute_data_size is interpreting
> that as "true" while fill_val is reading it as "false". According
> to my understanding of the C standard, fill_val is in the wrong here.
Is the _Bool representation allowed to contain anything but zero/false
or one/true? I thought that was undefined behavior. (IIRC, mixing C++
bool with our C89-era bool definition suffered from similar UB
excitement.)
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bryan Green | 2026-09-16 17:39:27 | Re: pgsql: Revert online data checksum transitions |
| Previous Message | Tom Lane | 2026-09-16 17:14:06 | Re: pgsql: Revert online data checksum transitions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bryan Green | 2026-09-16 17:39:27 | Re: pgsql: Revert online data checksum transitions |
| Previous Message | shihao zhong | 2026-09-16 17:20:13 | Re: Add TOAST statistics columns to pg_stat_all_tables |