| From: | surya poondla <suryapoondla4(at)gmail(dot)com> |
|---|---|
| To: | Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Kiran Kaki <itskkpg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: pg_walinspect: fix LSN validation messages and empty range handling |
| Date: | 2026-09-24 18:29:19 |
| Message-ID: | CAOVWO5rS47aFciEtwg3zTnp+DQn8TAm2eo1aSCSNbv=eBNGD-g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao,
Thanks for the v5 patch (all the points that were earlier raised were
addressed). Both patches apply with git am, the build is clean with no new
warnings.
I also checked that advancing the origin doesn't leak into the rest of
subscription.sql: no later test sets a skip LSN with a valid location, and
the
new block leaves subskiplsn reset to NONE, so nothing downstream depends on
the origin position.
No further comments from me, v5 looks ready for a committer. You can create
a commitfest entry for this.
Regards,
Surya Poondla
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2026-09-24 18:30:21 | RE: Recovery at replica stuck because recovery incorrectly trusts an old high-water mark |
| Previous Message | Masahiko Sawada | 2026-09-24 18:08:43 | Re: Adding a range check on the sequence index from the publisher. |