| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | Kiran Kaki <itskkpg(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: pg_walinspect: fix LSN validation messages and empty range handling |
| Date: | 2026-09-24 01:03:24 |
| Message-ID: | CABPTF7WvtdfjeEYLMWJihAy7XzAgpVzpNe+W+AJ3AzfX0FefXg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 24, 2026 at 7:14 AM Kiran Kaki <itskkpg(at)gmail(dot)com> wrote:
> Hi Chao
>
> >
> > PFA v5:
> >
> > * 0001: only added Surya as a reviewed in the commit message
> > * 0002: addressed Surya’s review comments
> >
>
> Thanks for addressing the review comments . All four issues are fixed in
> v5.
>
> Reviewed and tested on master (d39fda1cc4):
>
> - Both patches apply cleanly.
> - Build succeeds.
> - pg_walinspect tests pass.
> - psql tests pass.
> - Core regression tests pass.
> - Manually verified: ERROR: skip WAL location (LSN 0/00012345) must be
> greater than or equal to origin LSN 0/00012346
>
> Looks ready for a committer.
>
+1. v5 LGTM.
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | zengxx | 2026-09-24 01:16:34 | Skip a redundant singleton GROUP BY node |
| Previous Message | Michael Paquier | 2026-09-24 01:01:02 | Re: Add a permission check to pg_stat_get_backend_subxact() |