| From: | surya poondla <suryapoondla4(at)gmail(dot)com> |
|---|---|
| To: | Baji Shaik <baji(dot)pgdev(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: two small tab-completion patches (ALTER CONSTRAINT, CHECK modifiers) |
| Date: | 2026-10-27 22:23:09 |
| Message-ID: | CAOVWO5pzB0_98Q_PfrexdgCoBBBKG8=zXqUwGjwH96XxvwJdPw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Baji,
I tested v3 together with the CHECK patch on top of b936425002c. Both apply
cleanly and build without warnings. Driving psql through a pty
and comparing against master:
- ALTER CONSTRAINT fk DEFERRABLE <tab> offers INITIALLY DEFERRED and
INITIALLY IMMEDIATE, and DEFERRABLE INITIALLY <tab> offers DEFERRED
and IMMEDIATE.
- ALTER CONSTRAINT fk NOT DEFERRABLE <tab> completes to INITIALLY IMMEDIATE.
- Everything that worked in v2, including the CHECK modifiers, gives the
same output in v3, and the neighbouring ALTER TABLE rules are
identical to master.
The new forms are all accepted by the server, and src/bin/psql/t/
010_tab_completion.pl passes.
One correction to my previous mail, v2 of the CHECK patch applies to master
on its own as well.
v3 looks good to me.
Regards,
Surya Poondla
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-10-27 22:24:16 | Re: Parallel vacuum: check XID wraparound failsafe between indexes |
| Previous Message | Bharath Rupireddy | 2026-10-27 22:17:55 | Re: Parallel vacuum: workers together with leader could overrun cost budget |