| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Parallel vacuum: check XID wraparound failsafe between indexes |
| Date: | 2026-10-27 22:24:16 |
| Message-ID: | CAN4CZFO7p2EMKMKFBfWTGhwkyK=ZBPe8H6XYwhWWMg9t0Tz=AA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
One mostly nitpick question:
+extern bool parallel_vacuum_failsafe_triggered(ParallelVacuumState *pvs);
extern void parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs,
parallel_vacuum_bulkdel_all_indexes now might return quietly and
process only part of the work. Previously it either errored out, or
completed everything. Wouldn't it be be better to give it a return
value callers can check? Existing functions, such as
lazy_vacuum_all_indexes already do this. In this case the current
patch seems to be safe because of the lazy_check_wraparound_failsafe
call, but returning the status (and handling it in vacuumlazy) seems
like a safer not heap specific API.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-10-27 22:30:47 | Re: [PROPOSAL] Expand OR clauses in joins to UNION ALL paths |
| Previous Message | surya poondla | 2026-10-27 22:23:09 | Re: two small tab-completion patches (ALTER CONSTRAINT, CHECK modifiers) |