| From: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improve errmsg for publication membership |
| Date: | 2026-06-03 06:05:00 |
| Message-ID: | CAON2xHP_z++o7NSMsE-gcG1+qhwtiOy-NoJkrw+qzwMRbkZJ2g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here is a patch to reword 2 publication error messages:
>
> BEFORE/AFTER
> "relation \"%s\" is already member of publication \"%s\"",
> "relation \"%s\" is already a member of publication \"%s\"",
>
> BEFORE/AFTER
> "schema \"%s\" is already member of publication \"%s\"",
> "schema \"%s\" is already a member of publication \"%s\"",
>
> ~~~
>
> All other 'member of' error messages in PostgreSQL source are using
> correct grammar ('a member of'), so IMO these should do likewise.
>
> PSA v1.
Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245). LGTM.
Regards,
Ewan
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Mohamed ALi | 2026-06-03 05:58:23 | Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION |