Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION

From: Mohamed ALi <moali(dot)pg(at)gmail(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] doc: Document that invalid indexes are skipped during ATTACH PARTITION
Date: 2026-06-03 05:58:23
Message-ID: CAGnOmWpiG7nSRKgKOKPDCfUMaz4YvOt9Uwt2ETiY5qKTOg0Txg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Sami,

Thanks for the review. I agree, rewriting the existing sentence reads
much better than appending a separate one.

I've adopted your suggestion in v2, with one addition: a sentence
noting that invalid indexes remain on the partition and
should be dropped manually if no longer needed.
I think this helps make it clear that the user is responsible for
cleaning those up.

The full paragraph now reads:

For each index in the target table, if a valid equivalent
index already exists in the partition, it will be attached
to the target table's index, as if ALTER INDEX ATTACH
PARTITION had been executed; otherwise, a corresponding
one will be created. Any invalid indexes on the partition remain
unchanged and should be dropped manually if they are no longer
needed.

v2 patch attached.

--
Mohamed Ali

Attachment Content-Type Size
v2-0001-doc-attach-partition-invalid-index-skip.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ewan Young 2026-06-03 06:05:00 Re: Improve errmsg for publication membership
Previous Message Japin Li 2026-06-03 05:58:13 Re: Report oldest xmin source when autovacuum cannot remove tuples