Re: Fix error handling in getCopyDataMessage and pqFunctionCall3

Hi Fujii,

On Mon, Aug 3, 2026 at 5:44 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Thu, Jul 23, 2026 at 5:19 PM Anthonin Bonnefoy
> <anthonin(dot)bonnefoy(at)datadoghq(dot)com> wrote:
> > I've updated the patch to move the error checks before pqParseDone in
> > both cases.
>
> Thanks for updating the patch!
>
> Attached is an updated version.
> I only revised the commit message, the code is unchanged.

Thanks for the updated version. I re-checked v3 and it looks good to me.

>
> Since seems this issue was introduced by commit f6f0542266f0, which was
> backpatched to v18, I think this fix should be backpatched to v18 as well.
> Thought?

On backpatching: +1 for v18. f6f0542266f0 is present on REL_18_STABLE -
getNotify()/getParameterStatus() there already take the
handleFatalError()+return-0 path, and
REL_18's getCopyDataMessage()/pqFunctionCall3() don't have the check yet.

>
> Barring any objections, I'll commit it.
>
> Regards,
>
> --
> Fujii Masao

--
Regards,
Ewan Young