Re: Fix error handling in getCopyDataMessage and pqFunctionCall3

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Cc: Ewan Young <kdbase(dot)hack(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix error handling in getCopyDataMessage and pqFunctionCall3
Date: 2026-08-03 09:44:27
Message-ID: CAHGQGwGxMhy+AFxS_-RvReGqx+0MALqiBDfa_C4xOtgOpn1iOA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 23, 2026 at 5:19 PM Anthonin Bonnefoy
<anthonin(dot)bonnefoy(at)datadoghq(dot)com> wrote:
> I've updated the patch to move the error checks before pqParseDone in
> both cases.

Thanks for updating the patch!

Attached is an updated version.
I only revised the commit message, the code is unchanged.

Since seems this issue was introduced by commit f6f0542266f0, which was
backpatched to v18, I think this fix should be backpatched to v18 as well.
Thought?

Barring any objections, I'll commit it.

Regards,

--
Fujii Masao

Attachment Content-Type Size
v3-0001-Fix-error-handling-in-getCopyDataMessage-and-pqFu.patch application/octet-stream 2.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Pyhalov 2026-08-03 09:45:57 Re: Bug in asynchronous Append
Previous Message chee.wooson 2026-08-03 09:40:08 [PATCH v4] Fix exported snapshot xmin handoff race