Re: Allow auto_explain to log plans before queries are executed

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow auto_explain to log plans before queries are executed
Date: 2020-03-05 13:46:54
Message-ID: CAOBaU_bfnj9QU1eqWrJCAfDo+PcpZg0cNfwVfvt6wfpD5Ngdpw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 27, 2020 at 7:31 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
> On Thu, Feb 27, 2020 at 7:12 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> >
> > čt 27. 2. 2020 v 7:01 odesílatel Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> napsal:
> >> I think "query debugger" feature you proposed is out of scope of
> >> auto_explain module. I also think the feature to analyze running
> >> query online is great, but we will need another discussion on a new
> >> module or eature for it.
> >
> >
> > sure. My note was about using auto_explain like query_debugger. It has not too sense, and from this perspective, the original proposal to log plan before execution has more sense.
> >
> > you can log every plan with higher cost than some constant.
>
> Yes I thought about that too. If you're not in an OLAP environment
> (or with a specific user running few expensive queries), setup an
> auto_explain.log_before_execution_min_cost.

There was some discussion but no clear consensus on what should really
be done. I'm marking the patch as waiting on author which seems more
accurate. Feel free to switch it back if that's a wrong move.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-03-05 13:48:38 Should we remove a fallback promotion? take 2
Previous Message Daniel Gustafsson 2020-03-05 13:38:30 Retiring support for pre-7.3 FK constraint triggers