| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Lazy allocation of pages required for verifying FPI consistency |
| Date: | 2023-01-12 08:37:38 |
| Message-ID: | CAOBaU_aoCdobmRPtxTFNUF8zeNOvyrwWkL4E=yhofgpY2eEZSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 12, 2023 at 4:29 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Mon, 9 Jan 2023 20:00:00 +0530, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> > I propose to statically allocate these two pages using PGAlignedBlock
> > structure lazily in verifyBackupPageConsistency() to not waste dynamic
> > memory worth 2*BLCKSZ bytes. I'm attaching a small patch herewith.
> >
> > Thoughts?
>
> IMHO, it's a bit scaring to me to push down the execution stack by
> that large size. I tend to choose the (current) possible memory
> wasting only on startup process than digging stack deeply.
+1
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthonin Bonnefoy | 2023-01-12 08:45:31 | Re: Flush SLRU counters in checkpointer process |
| Previous Message | Kyotaro Horiguchi | 2023-01-12 08:29:28 | Re: Lazy allocation of pages required for verifying FPI consistency |