| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checksum errors in pg_stat_database |
| Date: | 2019-04-07 16:29:50 |
| Message-ID: | CAOBaU_anK5x3hDjG6mzfWgayoe+0qM1kkHWPW1U=X89xfLSujg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for looking it it!
On Sun, Apr 7, 2019 at 4:36 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> I'm not sure I like the idea of using "<shared_objects>" as the database name. It's not very likely that somebody would be using that as a name for their database, but i's not impossible. But it also just looks strrange. Wouldn't NULL be a more appropriate choice?
>
> Likewise, shouldn't we return NULL as the number of backends for the shared counters, rather than 0?
I wanted to make things more POLA-compliant, but maybe it was a bad
idea. I changed it for NULL here and for numbackends.
> Micro-nit:
> + <entry>Time at which the last data page checksum failures was detected in
> s/failures/failure/
Oops.
v5 attached.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_stat_checksums-v5.diff | text/x-patch | 11.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-04-07 16:48:11 | Re: Speed up transaction completion faster after many relations are accessed in a transaction |
| Previous Message | Fabien COELHO | 2019-04-07 16:22:46 | Re: pgbench - add minimal stats on initialization |