| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checksum errors in pg_stat_database |
| Date: | 2019-04-12 12:18:11 |
| Message-ID: | CABUevEyMO4qUJwvvhb9TVqrioh_PiikHDMAZXa611_8GSOVB_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Apr 7, 2019 at 6:28 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> Thanks for looking it it!
>
> On Sun, Apr 7, 2019 at 4:36 PM Magnus Hagander <magnus(at)hagander(dot)net>
> wrote:
> >
> > I'm not sure I like the idea of using "<shared_objects>" as the database
> name. It's not very likely that somebody would be using that as a name for
> their database, but i's not impossible. But it also just looks strrange.
> Wouldn't NULL be a more appropriate choice?
> >
> > Likewise, shouldn't we return NULL as the number of backends for the
> shared counters, rather than 0?
> I wanted to make things more POLA-compliant, but maybe it was a bad
> idea. I changed it for NULL here and for numbackends.
>
> > Micro-nit:
> > + <entry>Time at which the last data page checksum failures was
> detected in
> > s/failures/failure/
>
> Oops.
>
> v5 attached.
>
Thanks. Pushed!
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fred .Flintstone | 2019-04-12 12:25:30 | Re: PostgreSQL pollutes the file system |
| Previous Message | Michael Paquier | 2019-04-12 12:07:07 | Re: Calling pgstat_report_wait_end() before ereport(ERROR) |