From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. |
Date: | 2018-04-10 17:27:27 |
Message-ID: | CAOBaU_ZxAa33ZdCqSQbK4hHzbthR522M8X61nYgf6v7CTOrT0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 10, 2018 at 6:58 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Well, the question that's bothering me is how come "make check" in
> an external build doesn't try to execute the temp-install rule before
> printing that error message. Experimentation shows that it doesn't,
> but it sure looks to me like it should: there's nothing conditional
> about the "check: temp-install" dependency in Makefile.global. And
> none of the three if-guards in the temp-install rule itself should
> prevent this, so what is preventing it? I don't see it.
I just checked, and for the record the second rule (ifneq
($(abs_top_builddir),) is actually preventing it. On top of
Makefile.global:
# Set top_srcdir, srcdir, and VPATH.
ifdef PGXS
top_srcdir = $(top_builddir)
[...]
else # not PGXS
[...]
abs_top_builddir = @abs_top_builddir@
[...]
endif # not PGXS
>
> For this reason, I thought that adding NO_TEMP_INSTALL would be a good
> safety factor in case somebody changes/breaks whatever unobvious
> thing is keeping this from failing, and so I went ahead and did it.
It makes sense. Thanks for correcting and pushing!
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-04-10 17:47:43 | Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. |
Previous Message | Tom Lane | 2018-04-10 16:58:10 | Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. |
From | Date | Subject | |
---|---|---|---|
Next Message | Devrim Gündüz | 2018-04-10 17:41:31 | Re: submake-errcodes |
Previous Message | Tom Lane | 2018-04-10 17:22:52 | Re: Boolean partitions syntax |